Skip to content

Samples soft delete policy#63

Open
shubhangi-google wants to merge 1 commit into
mainfrom
samples_soft_delete_policy
Open

Samples soft delete policy#63
shubhangi-google wants to merge 1 commit into
mainfrom
samples_soft_delete_policy

Conversation

@shubhangi-google

Copy link
Copy Markdown
Owner

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
  • Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running bundle exec rake ci in the gem subdirectory.
  • Update code documentation if necessary.

closes: #<issue_number_goes_here>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new sample scripts and acceptance tests for Google Cloud Storage soft delete features, including setting, getting, and disabling soft delete policies, as well as listing and restoring soft-deleted objects. The review feedback recommends removing leftover binding.pry debugging statements from two of the new sample files and converting the generation command-line argument to an integer in the restore script.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread google-cloud-storage/samples/storage_set_soft_delete_policy.rb
Comment thread google-cloud-storage/samples/storage_restore_object.rb

@thiyaguk09 thiyaguk09 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve Gemini comments.

Comment thread google-cloud-storage/samples/storage_disable_soft_delete.rb Outdated
Comment thread google-cloud-storage/samples/storage_get_soft_delete_policy.rb Outdated
Comment thread google-cloud-storage/samples/storage_list_soft_deleted_object_versions.rb Outdated
Comment thread google-cloud-storage/samples/storage_list_soft_deleted_objects.rb Outdated
Comment thread google-cloud-storage/samples/storage_restore_object.rb Outdated
Comment thread google-cloud-storage/samples/storage_set_soft_delete_policy.rb Outdated
@shubhangi-google shubhangi-google force-pushed the samples_soft_delete_policy branch from 0eef952 to 402431d Compare July 7, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants