refactor: lift generation type and prompt helpers into shared utils - #170
Merged
Conversation
dazzatronus
marked this pull request as draft
August 28, 2026 10:48
dazzatronus
marked this pull request as ready for review
August 31, 2026 02:37
|
🎉 This PR is included in version 2.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GENERATION_TYPEandpromptPropertydescribe how an asset type maps to a generated media kind and where a legacy speech asset keeps its prompt. Both are facts about assets, not about a toolbar, and both are needed outside the toolbar.Pure move: the two declarations are unchanged, the toolbar imports them from their new home, and its now-unused type import goes with them. No behaviour change.
Verify:
npm run verify:ci— the existing suite passes unmodified, which is the proof that nothing moved but the code.