Repository navigation
build(ci): upgrade Go 1.26 to 1.27.1 - #310
Merged
Merged
Conversation
Bump the go directive to 1.27.1, the latest stable release, and have both
workflows read the version from go.mod (matching the server) so CI cannot
drift from the module again.
Mockery v3.5.0 bundles golang.org/x/tools v0.33.0, which cannot load
packages for a go 1.27 module ("package without types was imported").
Bump it to v3.7.4, the version the server already runs on Go 1.27.1.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016nCMzAhia8nSVTafQzYZcr
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
godirective ingo.modfrom1.26to1.27.1, the latest stable Go release.pr-check.yaml,release.yaml) from a hard-codedgo-version: "1.26"togo-version-file: go.mod. The server already does this, and it keeps CI on the same version as the module.v3.5.0tov3.7.4in both workflows. v3.5.0 bundlesgolang.org/x/toolsv0.33.0, which can't load packages for ago 1.27module. It fails withinternal error: package "bufio" without types was imported from ".../model", even when built with go1.27.1. v3.7.4 is the version the server already uses on Go 1.27.1.CLAUDE.mdandAGENTS.md.go mod tidyunder go1.27.1 doesn't touchgo.sum.Test plan
All run locally on go1.27.1:
go mod tidythengo mod verify; a secondgo mod tidymakes no changesMockCommandService/MockConfigServicego vet ./...go build ./cmd/cli/main.goandgo build ./cmd/daemon/main.gogo test -timeout 3m ./...: commands, daemon, model, and stloader all pass🤖 Generated with Claude Code
https://claude.ai/code/session_016nCMzAhia8nSVTafQzYZcr
Generated by Claude Code