fix: use the parent session's current agent for exit notifications#52
Open
sjawhar wants to merge 1 commit into
Open
fix: use the parent session's current agent for exit notifications#52sjawhar wants to merge 1 commit into
sjawhar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#50 made exit notifications preserve the parent session's model, but they still pass the agent that was captured at spawn time. If the user switches agents while the PTY is running, the exit notification switches the session back.
This reuses the
session.getcall added in #50: prefer the parent session's currentagent, and fall back to the spawn-timeparentAgentwhen the server doesn't expose one (same graceful degradation as the model lookup).Added tests for both cases; the existing notification tests pass unchanged.