Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/plugin/pty/notification-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,36 @@ export class NotificationManager {

try {
const message = this.buildExitNotification(session, exitCode)
let modelContext: {
model?: { providerID: string; modelID: string }
variant?: string
} = {}
try {
const parent = await this.client.session.get({
path: { id: session.parentSessionId },
})
const model = (
parent.data as
| (typeof parent.data & {
model?: { id: string; providerID: string; variant?: string }
})
| undefined
)?.model
if (model) {
modelContext = {
model: { providerID: model.providerID, modelID: model.id },
...(model.variant ? { variant: model.variant } : {}),
}
}
} catch {
// Older OpenCode versions may not expose the session model.
}
await this.client.session.promptAsync({
path: { id: session.parentSessionId },
body: {
parts: [{ type: 'text', text: message }],
...(session.parentAgent ? { agent: session.parentAgent } : {}),
...modelContext,
},
})
} catch {
Expand Down
72 changes: 69 additions & 3 deletions test/notification-manager.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ type PromptPayload = {
body: {
parts: Array<{ type: string; text: string }>
agent?: string
model?: { providerID: string; modelID: string }
variant?: string
}
}

Expand Down Expand Up @@ -38,6 +40,67 @@ function createSession(overrides: Partial<PTYSession> = {}): PTYSession {
}

describe('NotificationManager', () => {
it('preserves the parent session model and variant', async () => {
const get = mock(async () => ({
data: {
model: { providerID: 'openai', id: 'gpt-5.6-terra', variant: 'high' },
},
}))
const promptAsync = mock(async (_payload: PromptPayload) => {})
const manager = new NotificationManager()

manager.init({ session: { get, promptAsync } } as unknown as OpencodeClient)

await manager.sendExitNotification(createSession(), 0)

expect(get).toHaveBeenCalledWith({ path: { id: 'parent-session-id' } })
const payload = promptAsync.mock.calls[0]?.[0]
if (!payload) throw new Error('Expected a prompt payload')
expect(payload.body.model).toEqual({
providerID: 'openai',
modelID: 'gpt-5.6-terra',
})
expect(payload.body.variant).toBe('high')
})

it('preserves the parent model without inventing a variant', async () => {
const get = mock(async () => ({
data: { model: { providerID: 'openai', id: 'gpt-5.6-terra' } },
}))
const promptAsync = mock(async (_payload: PromptPayload) => {})
const manager = new NotificationManager()

manager.init({ session: { get, promptAsync } } as unknown as OpencodeClient)

await manager.sendExitNotification(createSession(), 0)

const payload = promptAsync.mock.calls[0]?.[0]
if (!payload) throw new Error('Expected a prompt payload')
expect(payload.body.model).toEqual({
providerID: 'openai',
modelID: 'gpt-5.6-terra',
})
expect(Object.hasOwn(payload.body, 'variant')).toBe(false)
})

it('sends the notification when reading the parent model fails', async () => {
const get = mock(async () => {
throw new Error('Session API unavailable')
})
const promptAsync = mock(async (_payload: PromptPayload) => {})
const manager = new NotificationManager()

manager.init({ session: { get, promptAsync } } as unknown as OpencodeClient)

await manager.sendExitNotification(createSession(), 0)

expect(promptAsync).toHaveBeenCalledTimes(1)
const payload = promptAsync.mock.calls[0]?.[0]
if (!payload) throw new Error('Expected a prompt payload')
expect(Object.hasOwn(payload.body, 'model')).toBe(false)
expect(Object.hasOwn(payload.body, 'variant')).toBe(false)
})

it('includes body.agent when originating agent is present', async () => {
const promptAsync = mock(async (_payload: PromptPayload) => {})
const manager = new NotificationManager()
Expand All @@ -47,7 +110,8 @@ describe('NotificationManager', () => {
await manager.sendExitNotification(createSession({ parentAgent: 'agent-two' }), 0)

expect(promptAsync).toHaveBeenCalledTimes(1)
const payload = promptAsync.mock.calls[0]![0]
const payload = promptAsync.mock.calls[0]?.[0]
if (!payload) throw new Error('Expected a prompt payload')

expect(payload.path).toEqual({ id: 'parent-session-id' })
expect(payload.body.agent).toBe('agent-two')
Expand All @@ -65,7 +129,8 @@ describe('NotificationManager', () => {
await manager.sendExitNotification(createSession({ parentAgent: undefined }), 1)

expect(promptAsync).toHaveBeenCalledTimes(1)
const payload = promptAsync.mock.calls[0]![0]
const payload = promptAsync.mock.calls[0]?.[0]
if (!payload) throw new Error('Expected a prompt payload')

expect(payload.path).toEqual({ id: 'parent-session-id' })
expect(Object.hasOwn(payload.body, 'agent')).toBe(false)
Expand All @@ -85,7 +150,8 @@ describe('NotificationManager', () => {
await manager.sendExitNotification(createSession({ timeoutSeconds: 2, timedOut: true }), 0)

expect(promptAsync).toHaveBeenCalledTimes(1)
const payload = promptAsync.mock.calls[0]![0]
const payload = promptAsync.mock.calls[0]?.[0]
if (!payload) throw new Error('Expected a prompt payload')
const text = payload.body.parts[0]?.text ?? ''

expect(text).toContain('TimeoutSeconds: 2')
Expand Down
Loading