Null check before walk to handle null values#19
Open
chajath wants to merge 3 commits intoshaunxcode:masterfrom
Open
Null check before walk to handle null values#19chajath wants to merge 3 commits intoshaunxcode:masterfrom
chajath wants to merge 3 commits intoshaunxcode:masterfrom
Conversation
added 2 commits
December 3, 2014 16:38
I.e. previously
edn.unify('{:x nil :y ?xxx}', '{:xxx 42}');
was failing due to null not having 'walk' as a member function.
With this change I confirmed the said example works fine.
Author
|
I won't commit jsedn.js as I am not sure what version of component we are using here. jsedn.js built from latest component generates file that are quite different in many places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I.e. previously
edn.unify('{:x nil :y ?xxx}', '{:xxx 42}');
was failing due to null not having 'walk' as a member function.
With this change I confirmed the said example works fine.