Fix: Sort task JSON files numerically instead of lexicographically#122
Open
chablino wants to merge 3 commits intoshareAI-lab:mainfrom
Open
Fix: Sort task JSON files numerically instead of lexicographically#122chablino wants to merge 3 commits intoshareAI-lab:mainfrom
chablino wants to merge 3 commits intoshareAI-lab:mainfrom
Conversation
|
@chablino is attempting to deploy a commit to the crazyboym's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Fixes task listing order in the s07 task system by sorting task_*.json files by numeric id rather than lexicographic filename order, so task_2.json correctly appears before task_10.json.
Changes:
- Adds a custom
keyto thesorted()call inTaskManager.list_all()to sort by the numeric suffix in the filename. - Refactors the loop to sort into a
fileslist first, then iterate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently, the
list_allmethod ins07_task_system.pyrelies on the default string sorting behavior when readingtask_*.jsonfiles. This causes a lexicographical sorting issue where files are listed out of logical order (e.g.,task_10.jsonappears beforetask_2.json).Changes:
sorted()function by adding a customkey.lambdafunction to extract the numeric ID from the filename (f.stem.split("_")[-1]) and converted it to an integer.