Conversation
…ut by clouad opus 4.6 model
Updated devcontainer configuration to use Python image and added features for Node and Copilot CLI.
|
@rzzhangg is attempting to deploy a commit to the crazyboym's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Adds a VS Code dev container for a Python-based environment and introduces a large set of generated OpenRouter Python SDK reference docs under .github/skills.
Changes:
- Add
.devcontainer/devcontainer.jsonusing themcr.microsoft.com/devcontainers/python:3image plus Node + Copilot CLI features. - Add generated Markdown/JSON reference documentation for the OpenRouter Python SDK (hundreds of files).
- Add documentation metadata files (extraction/dependency statistics, contributing doc).
Reviewed changes
Copilot reviewed 296 out of 913 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .devcontainer/devcontainer.json | Defines the devcontainer image, features, post-create setup, and VS Code extensions/settings. |
| .github/skills/openrouter-python-sdk/references/** | Adds generated documentation/reference artifacts for the OpenRouter Python SDK, plus summary/stat files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,28 @@ | |||
| { | |||
| "name": "Learn Claude Code Dev Container", | |||
There was a problem hiding this comment.
The devcontainer name appears unrelated to this repository/PR ("Learn Claude Code Dev Container"). Consider renaming it to match the repo/project to avoid confusion when multiple devcontainers are used across projects.
| "name": "Learn Claude Code Dev Container", | |
| "name": "Project Dev Container", |
| "image": "mcr.microsoft.com/devcontainers/python:3", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/node:1": { | ||
| "version": "latest" |
There was a problem hiding this comment.
The container base image tag (python:3) and Node feature version (latest) are floating, which can make the devcontainer non-reproducible and cause unexpected breakages as new major/minor versions are released. Pin these to explicit versions (e.g., a specific Python variant tag and a specific Node major/minor) to keep builds stable.
| "image": "mcr.microsoft.com/devcontainers/python:3", | |
| "features": { | |
| "ghcr.io/devcontainers/features/node:1": { | |
| "version": "latest" | |
| "image": "mcr.microsoft.com/devcontainers/python:3.11", | |
| "features": { | |
| "ghcr.io/devcontainers/features/node:1": { | |
| "version": "20" |
| "postCreateCommand": { | ||
| "install-copilot-sdk": "copilot plugin install copilot-sdk@awesome-copilot" | ||
| }, |
There was a problem hiding this comment.
The postCreateCommand will fail the devcontainer setup if the copilot binary isn't present yet or if the referenced plugin (copilot-sdk@awesome-copilot) is unavailable/renamed. Consider making this step idempotent and resilient (e.g., check for the CLI/plugin before installing, and/or pin to a known-good plugin/version) so container creation doesn't break for contributors.
| "postCreateCommand": { | |
| "install-copilot-sdk": "copilot plugin install copilot-sdk@awesome-copilot" | |
| }, | |
| "postCreateCommand": "bash -lc 'if ! command -v copilot >/dev/null 2>&1; then echo \"copilot CLI not found; skipping copilot-sdk@awesome-copilot plugin install\"; exit 0; fi; if copilot plugin list 2>/dev/null | grep -q \"copilot-sdk@awesome-copilot\"; then echo \"copilot-sdk@awesome-copilot plugin already installed\"; else echo \"Installing copilot-sdk@awesome-copilot plugin\"; copilot plugin install copilot-sdk@awesome-copilot || echo \"Warning: failed to install copilot-sdk@awesome-copilot plugin\"; fi'", |
| { | ||
| "enhanced_files": 684, | ||
| "total_files": 684, |
There was a problem hiding this comment.
The PR description focuses on adding devcontainer.json, but this change set also adds a large generated documentation tree (684 files per extraction_summary.json). Please either (a) update the PR description to explicitly call out the documentation import and why it belongs in this PR, or (b) split the generated docs into a separate PR to keep review scope and history clearer.
devcontainer.json added
Base image: microsoft python3
Features: node and copilot cli