fix: remove hardcoded assistant ack after auto_compact to fix 400#118
Open
deanbear wants to merge 2 commits intoshareAI-lab:mainfrom
Open
fix: remove hardcoded assistant ack after auto_compact to fix 400#118deanbear wants to merge 2 commits intoshareAI-lab:mainfrom
deanbear wants to merge 2 commits intoshareAI-lab:mainfrom
Conversation
|
@deanbear is attempting to deploy a commit to the crazyboym's projects Team on Vercel. A member of the Team first needs to authorize it. |
s08/s09/s10/s11/s_full inject background-results and inbox as user messages before LLM calls. The paired hardcoded assistant "Noted..." responses were unnecessary — consecutive user messages work fine and the fake acks added noise with no functional value. Affected: agents/s08, s09, s10, s11, s_full + docs (zh/en/ja s08, s09)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan
Additional fix: remove hardcoded assistant acks (s08–s11)