Use canonical docs routes in site shell links#72
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 6 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Unused
ossVsProroute in docsRoutes constant- I removed the unused
ossVsProentry fromdocsRoutesafter confirming it has no references in the repository.
- I removed the unused
- ✅ Fixed: Inconsistent trailing slash on
docsGuideroute only- I changed
docsGuidefrom/docs/to/docsto match the existing route convention and prior behavior.
- I changed
Or push these changes by commenting:
@cursor push 1b560f3c1e
Preview (1b560f3c1e)
diff --git a/prototypes/docusaurus/src/constants/docsRoutes.ts b/prototypes/docusaurus/src/constants/docsRoutes.ts
--- a/prototypes/docusaurus/src/constants/docsRoutes.ts
+++ b/prototypes/docusaurus/src/constants/docsRoutes.ts
@@ -1,8 +1,7 @@
export const docsRoutes = {
- docsGuide: '/docs/',
+ docsGuide: '/docs',
createApp: '/docs/getting-started/create-react-on-rails-app',
installExistingApp: '/docs/getting-started/installation-into-an-existing-rails-app',
- ossVsPro: '/docs/getting-started/oss-vs-pro',
proOverview: '/docs/pro',
proUpgrade: '/docs/pro/upgrading-to-pro',
migrateFromReactRails: '/docs/migrating/migrating-from-react-rails',You can send follow-ups to this agent here.
| docsGuide: '/docs/', | ||
| createApp: '/docs/getting-started/create-react-on-rails-app', | ||
| installExistingApp: '/docs/getting-started/installation-into-an-existing-rails-app', | ||
| ossVsPro: '/docs/getting-started/oss-vs-pro', |
There was a problem hiding this comment.
Unused ossVsPro route in docsRoutes constant
Low Severity
The ossVsPro entry in docsRoutes is defined but never referenced anywhere in the codebase. This PR replaced every former use of the /docs/getting-started/oss-vs-pro path with docsRoutes.proOverview, making ossVsPro dead code from the moment it was introduced.
| @@ -0,0 +1,9 @@ | |||
| export const docsRoutes = { | |||
| docsGuide: '/docs/', | |||
There was a problem hiding this comment.
Inconsistent trailing slash on docsGuide route only
Low Severity
docsGuide is defined as '/docs/' (with trailing slash) while every other route in the map omits the trailing slash. The original hardcoded value was "/docs" without a trailing slash. This inconsistency can cause mismatches with Docusaurus's link-active detection and differs from the convention used in the footer of docusaurus.config.ts, which also uses '/docs' without a trailing slash.
|
Cloudflare preview deployed.
|
1 participant
Summary
Testing
Closes #69