-
-
Notifications
You must be signed in to change notification settings - Fork 638
Enhance change detection & workflow triggers #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
453f02a
empty commit
Judahmeek 27f640e
universalize trigger settings for workflows
Judahmeek a8f30e9
add rakelib to change detection
Judahmeek bc9bfc8
add more granular detection of rakelib & workflows
Judahmeek b9d243a
Update .github/workflows/actionlint.yml
Judahmeek 83e6468
add force_run references
Judahmeek a48a222
misc
Judahmeek 01fe3e4
per review
Judahmeek a95a528
matrix strategy requires an initial matrix
Judahmeek c57a7d5
try using include instead of exclude
Judahmeek 18c8ebb
invert conditional logic
Judahmeek a84e852
update dummy-app-integration-tests job matrix strategy
Judahmeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| name: Lint JS and Ruby | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - 'master' | ||
| paths: | ||
| - '.github/workflows/**' | ||
| pull_request: | ||
| paths: | ||
| - '.github/workflows/**' | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| actionlint: | ||
| env: | ||
| BUNDLE_FROZEN: true | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| # No need for history in lint job | ||
| fetch-depth: 1 | ||
| persist-credentials: false | ||
| # We only download and run Actionlint if there is any difference in GitHub Action workflows | ||
| # https://github.com/rhysd/actionlint/blob/main/docs/usage.md#on-github-actions | ||
| - name: Check GitHub Action changes | ||
| id: check-workflows | ||
| run: | | ||
| BASE_SHA="${{ github.event.pull_request.base.sha || github.event.before }}" | ||
| if [ -n "$BASE_SHA" ]; then | ||
| git fetch origin "$BASE_SHA" 2>/dev/null || true | ||
| fi | ||
|
|
||
| # For PRs, diff against base; for pushes, use before commit | ||
| if [ -n "${{ github.event.pull_request.base.sha }}" ]; then | ||
| DIFF_BASE="${{ github.event.pull_request.base.sha }}" | ||
| else | ||
| DIFF_BASE="${{ github.event.before }}" | ||
| fi | ||
|
|
||
| if git diff --name-only "$DIFF_BASE" ${{ github.sha }} 2>/dev/null | grep -q '^.github/workflows'; then | ||
| echo "changed=true" >> "$GITHUB_OUTPUT" | ||
| response=$(curl -sf https://api.github.com/repos/rhysd/actionlint/releases/latest) | ||
| if [ $? -eq 0 ]; then | ||
| actionlint_version=$(echo "$response" | jq -r .tag_name) | ||
| if [ -z "$actionlint_version" ]; then | ||
| echo "Failed to parse Actionlint version" | ||
| exit 1 | ||
| fi | ||
| echo "actionlint_version=\"$actionlint_version\"" >> "$GITHUB_OUTPUT" | ||
| fi | ||
| fi | ||
Judahmeek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - name: Setup Actionlint | ||
| if: steps.check-workflows.outputs.changed == 'true' | ||
| uses: actions/cache@v4 | ||
| id: cache-actionlint | ||
| with: | ||
| path: ./actionlint | ||
| key: ${{ runner.os }}-actionlint-${{ steps.check-workflows.outputs.actionlint_version }} | ||
| - name: Download Actionlint | ||
| if: steps.check-workflows.outputs.changed == 'true' && steps.cache-actionlint.outputs.cache-hit != 'true' | ||
| run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) | ||
| - name: Lint GitHub Actions | ||
| if: steps.check-workflows.outputs.changed == 'true' | ||
| run: | | ||
| echo "::add-matcher::.github/actionlint-matcher.json" | ||
| SHELLCHECK_OPTS="-S warning" ./actionlint -color | ||
| shell: bash | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| name: Generator tests | ||
| name: Generator tests # TODO needs to be duplicated for RoR Pro | ||
|
|
||
| on: | ||
| push: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.