fix: Remove stdlib multiprocessing with pathos#47
Open
nkemnitz wants to merge 2 commits intoseung-lab:masterfrom
Open
fix: Remove stdlib multiprocessing with pathos#47nkemnitz wants to merge 2 commits intoseung-lab:masterfrom
nkemnitz wants to merge 2 commits intoseung-lab:masterfrom
Conversation
Contributor
|
Thanks for the fix Nico! I tried testing this both on GHA and locally and it seems to stall at the parallel test (test/test_taskqueue.py::test_parallel_insert_all[fq]). |
nkemnitz
force-pushed
the
nkem/mp-fix
branch
2 times, most recently
from
a73c932 to
70d3773
Compare
Contributor
Author
|
Right, the spawned child processes tried to create their own mp.Manager.Queue. Also test needs adjustment to that the child processes actually can communicate with the main process mock queue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46