Skip to content

Move ExtractIf iterator into its own module - #629

Draft
Kxrma47 wants to merge 3 commits into
servo:v2from
Kxrma47:refactor/extract-if-iterator-module
Draft

Kxrma47 wants to merge 3 commits into
servo:v2from
Kxrma47:refactor/extract-if-iterator-module

Conversation

@Kxrma47

@Kxrma47 Kxrma47 commented Sep 19, 2026

Copy link
Copy Markdown

Moves ExtractIf and its Debug, Iterator, and Drop implementations from lib.rs to src/iterators/extract_if.rs. Re-exports smallvec::ExtractIf; crate-visible fields allow the existing SmallVec::extract_if constructor to remain unchanged.

Part of #627. Independent of #628.

Validation: cargo test; cargo test --features 'std rayon serde borsh bytes arbitrary'; cargo clippy --all-targets -- -D warnings; cargo doc --no-deps. Nightly rustfmt is exercised by CI.

@alejandro-vaz

Copy link
Copy Markdown
Collaborator

there will be merge conflicts regarding the imports from lib.rs to the iterators with the other PR

@alejandro-vaz

Copy link
Copy Markdown
Collaborator

I'm withholding both of your PRs until v2.0.0-beta.1 gets released, it's a few hours / ~48 hours max, then they will get merged no worries

meanwhile I'm drafting them

thanks for contributing

@alejandro-vaz
alejandro-vaz marked this pull request as draft September 19, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants