Skip to content

allow v2 to always compile in MSRV with no features enabled #631

Description

@alejandro-vaz

yeah as of now, no default features = nightly only. once the allocator API stabilizes then it will use the proper API when the feature is disabled

I'm not sure but it seems wrong to me, I know no other crate that fails to compile with no default feature which usually means less strict, You might want to get some other feedback about it from the community.

Originally posted by @fereidani in #630 (comment)

instead, what we would do is have a allocator-api feature that does not then require the allocator-api2 dependency and use alloc, whilst when it is disabled it defaults to allocator-api2

it's just the inverse of what we have

and update the ./README.md feature description

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for a first contributorhelp wantedNo clear candidate to implement itr-refactorrelated to refactoring

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions