-
Notifications
You must be signed in to change notification settings - Fork 221
run may_dangle benchmarks on v2 #603
Copy link
Copy link
Open
Labels
good first issueGood for a first contributorGood for a first contributorhelp wantedNo clear candidate to implement itNo clear candidate to implement itr-performancerelated to performancerelated to performance
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
good first issueGood for a first contributorGood for a first contributorhelp wantedNo clear candidate to implement itNo clear candidate to implement itr-performancerelated to performancerelated to performance
we are trying to assess what performance benefits does
may_danglehaverun
cargo benchandcargo bench --features may_dangle, and open a PR with no changes and the table as descriptionif there are barely any / no performance improvements, maybe we should just remove it instead of having arbitrary features with no ROI
if benchmarks don't really reflect the use case where this feature might perform better, add some bench for it that shows that it makes a difference, if you can find one