Closed
Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
Contributor
Author
|
Servo results: https://github.com/servo/servo/actions/runs/23119769751 A lot of failures unfortunately. |
Contributor
Author
|
Probably just going to abandon this for now as making this work (and testing that it's correct and actually faster) looks like it's going to be quite involved, and this is not high-priority for me. If anyone else wants to take this on, then please feel free to adopt this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for testing/discussion.
Looks like it's failing the tests because it's writing values with full precision rather than a restricted precision of "6" for f32 and "15" for f64 (which appears to be the significance of the
-shortindtoa-short). I guess we'd need azmij-shortcrate for output parity. Or alternatively just accept the more precise/verbose output.