fix issue that integer 1000001 is written as 1000000 #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenw97
changed the title
Member
|
it seems we could just early-return for int values instead, right? That would be cleaner. |
Contributor
Author
I do try to return early, but it fails at case where the -0 is printed as 0 with the '-" sign ignore. |
edenw97
force-pushed
the
fix_interger_serialization
branch
from
85dc7b6 to
526ef82
Compare
Contributor
Author
|
@emilio Hi emilio, would you please review my comment and see if other feedback for the PR? |
emilio
approved these changes
Nov 29, 2025
Member
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
Looks good, thanks! I'll land the suggested clean-ups in a follow-up PR.
|
|
||
| let notation = if value == 0.0 && value.is_sign_negative() { | ||
| // Negative zero. Work around #20596. | ||
| dest.write_str("-0")?; |
| scientific: false, | ||
| } | ||
| } else if let Some(int_val) = int_value { | ||
| write!(dest, "{}", int_val)?; |
| dtoa_short::write(dest, value)? | ||
| }; | ||
|
|
||
| if int_value.is_none() && value.fract() == 0. && !notation.decimal_point && !notation.scientific |
Member
There was a problem hiding this comment.
Then int_value.is_none() can be dropped
Member
|
#421 is the follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.