Add backslash line continuation to package install scripts - #708
Closed
ryanjbonnell wants to merge 8 commits into
Closed
ryanjbonnell wants to merge 8 commits into
ryanjbonnell wants to merge 8 commits into
Conversation
jaydrogers
changed the base branch from
main
to
release/webserver-improvements-and-fixes
September 25, 2026 23:49
…erversideup#709) Bumps [@serversideup/project-switcher-bar](https://github.com/serversideup/project-switcher-bar) from 0.0.6 to 0.0.9. - [Commits](serversideup/project-switcher-bar@v0.0.6...v0.0.9) --- updated-dependencies: - dependency-name: "@serversideup/project-switcher-bar" dependency-version: 0.0.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jaydrogers
pushed a commit
that referenced
this pull request
Oct 1, 2026
…cripts Previously only the first argument was used, so packages passed as separate arguments were silently skipped. Also disables globbing while splitting and skips the install when no packages are given. From #708. Resolved conflicts with the release branch and added a ShellCheck directive for the intentional word split.
Member
|
Thanks @ryanjbonnell! It fixed a bug I didn't know we had. The script only read the first argument, so packages passed as separate arguments were silently skipped 🤪 I cherry-picked your commits into #645 instead of merging this PR because there were some merge conflicts. I resolved the conflicts and added a ShellCheck directive so it passes our lint. The commit is still under your name: I also cleaned up my own code after you added this great improvement. It all ships with 5.0. Thanks again 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update allows for packages to be installed using line continuation, improving the developer experience writing Dockerfile commands.
Presently, the
docker-php-serversideup-dep-install-debian(or-alpine) commands allow for one or more packages to be installed using spaces or commas:With these changes, the command can now accept packages across lines using the backspace line continuation method, as well as other existing methods.
RUN docker-php-serversideup-dep-install-debian \ bat \ eza \ fd-find \ less \ nano \ ripgrep \ zipThis greatly increases readability, and allows for cleaner diffs when many packages are listed. It remains fully backwards compatible with no breaking changes.
If by chance an empty string is passed in as an argument, an INFO message is displayed and allows the script to continue with an exit code of zero.
I've found this to be immensely helpful in my own work and wanted to share it with others.