Skip to content

Style start/end node components #202

Open
kumaradityaraj wants to merge 5 commits into
serverlessworkflow:mainfrom
kumaradityaraj:startEndNode
Open

Style start/end node components #202
kumaradityaraj wants to merge 5 commits into
serverlessworkflow:mainfrom
kumaradityaraj:startEndNode

Conversation

@kumaradityaraj

Copy link
Copy Markdown
Contributor

Closes

Style Start and End Nodes and Verify Edge Connectivity

Summary

This PR applies the finalized styling for the custom Start and End workflow nodes and validates their connectivity within the editor. The implementation aligns with the agreed design, providing clear visual indicators for workflow entry and exit points.

Changes

  • Applied custom styling to Start and End nodes.
  • Updated node appearance to match Mermaid-style start and end points.
  • Verified edge rendering for:
    • Start → Standard nodes
    • Standard nodes → End
    • Start → End
    • Complex workflows containing multiple intermediate nodes
  • Confirmed correct connection behavior between custom nodes and standard task nodes.
  • Added/updated tests to validate edge rendering and node connectivity.

Screenshots

Screenshot 2026-06-25 at 3 12 18 PM Screenshot 2026-06-25 at 3 12 25 PM

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Copilot AI review requested due to automatic review settings June 25, 2026 10:09
@netlify

netlify Bot commented Jun 25, 2026

Copy link
Copy Markdown

Deploy Preview for swf-editor ready!

Name Link
🔨 Latest commit 8a4c8a3
🔍 Latest deploy log https://app.netlify.com/projects/swf-editor/deploys/6a3e6874f9f486000800e588
😎 Deploy Preview https://deploy-preview-202--swf-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the placeholder Start/End React Flow nodes with a dedicated StartEndNode component and introduces corresponding CSS to render Mermaid-style start (single circle) and end (double circle) markers in the workflow diagram editor.

Changes:

  • Added a shared StartEndNode renderer and wired it into StartNode/EndNode.
  • Added new CSS classes for start/end node shapes, plus selected/hover styling.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
packages/serverless-workflow-diagram-editor/src/react-flow/nodes/Nodes.tsx Adds StartEndNode and updates Start/End node components to render it.
packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.css Adds styling for the new start/end node shapes and their interaction states.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.css Outdated
@lornakelly

Copy link
Copy Markdown
Contributor

@kumaradityaraj I know not ready for review but I know I mentioned the grey like the edge but looks a bit off next to diagram, can you try the same colours as what we style the entry/exit nodes for light and dark themes please

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Copilot AI review requested due to automatic review settings June 26, 2026 11:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread packages/serverless-workflow-diagram-editor/src/react-flow/nodes/Nodes.tsx Outdated
Comment thread packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.css Outdated
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
@kumaradityaraj

Copy link
Copy Markdown
Contributor Author

@lornakelly @fantonangeli @handreyrc Please review this PR. Special attention to colour of the node must be verified as mentioned by Lorna in the above comment.

@lornakelly

lornakelly commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@kumaradityaraj It doesnt look like the colours are updated to match entry/exit nodes?
#202 (comment)
Screenshot 2026-06-26 at 13 50 04

Once that is done I will review rest of PR, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants