Implement tooltip on custom call type#182
Open
kumaradityaraj wants to merge 8 commits into
Open
Conversation
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
✅ Deploy Preview for swf-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR replaces the browser default title tooltip for unknown task badges with the app’s Tooltip component to provide a consistent UI.
Changes:
- Adds Tooltip UI components to
Nodes.tsx - Wraps custom/unknown badges with
TooltipTriggerandTooltipContent - Introduces inline color styling based on
prefers-color-scheme
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@lornakelly Please review this. |
lornakelly
reviewed
Jun 17, 2026
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
kumaradityaraj
requested review from
cheryl7114,
fantonangeli,
handreyrc and
lornakelly
lornakelly
reviewed
Jun 25, 2026
| color: color-mix(in srgb, var(--task-node-color) 18%, white); | ||
| background-color: color-mix(in srgb, var(--task-node-color) 40%, transparent); | ||
| } | ||
| }ho |
| @@ -17,7 +17,7 @@ catalogs: | |||
| version: 5.2.1 | |||
Contributor
There was a problem hiding this comment.
You have not added dependencies so the lock file should not be changed, you might be out of sync locally
| const callBadge = screen.getByTestId("call-node-n1-badge-custom"); | ||
| expect(callBadge).toBeInTheDocument(); | ||
| expect(callBadge.textContent).toBe("customCall"); | ||
| expect(callBadge).toHaveAttribute("title", "customCall"); |
Contributor
There was a problem hiding this comment.
Need to add a test to verify correct tooltip content is displayed
Contributor
|
@kumaradityaraj also make sure to add changeset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
A small, reusable tooltip component and use it to replace the native browser title tooltip currently shown on custom call type badges.