Skip to content

Conversation

@43081j
Copy link
Contributor

@43081j 43081j commented Jan 13, 2026

This package has been redundant for a very long time but unfortunately
has failed to mark itself as deprecated.

Node ships a built-in isBuiltin function which achieves the same and
is supported by all versions of Node this repo supports.

How can we verify it:

Existing tests should be sufficient.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: Yes
Is it a breaking change?: No

This package has been redundant for a very long time but unfortunately
has failed to mark itself as deprecated.

Node ships a built-in `isBuiltin` function which achieves the same and
is supported by all versions of Node this repo supports.
@j0k3r
Copy link
Member

j0k3r commented Jan 13, 2026

Why not.
Can you fix the linter? (and it's ok if the build with Serverless v4 fails, it's not stable)
Can increase the minimum Node version to 18.6.0 instead of just 18? It seems isBuiltin has been improved in Node 18.6.0: https://nodejs.org/api/module.html#moduleisbuiltinmodulename

@43081j
Copy link
Contributor Author

43081j commented Jan 13, 2026

16 does support this but im happy to bump the engine version still if you'd prefer

let me know!

have also fixed the lint problem

@j0k3r
Copy link
Member

j0k3r commented Jan 13, 2026

Okay, I just saw that it was added to both versions at the same time. I thought it was added in version 16.17.0 and improved in version 18.6.0.

Thanks for the PR.
Also, I really like the e18e initiative, thanks for leading it!

@j0k3r j0k3r merged commit 4518738 into serverless-heaven:master Jan 13, 2026
12 of 13 checks passed
@43081j 43081j deleted the ibm branch January 13, 2026 11:17
@43081j
Copy link
Contributor Author

43081j commented Jan 13, 2026

thanks for the quick review 🙏

and thats great to hear you're a fan of e18e! it'd be great to have you in the discord some day if you ever want to join

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants