You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Mixed String and Symbol overrides send duplicate parameters #45
I searched existing issues, open and closed, and found no general mixed-key override fix
I can reproduce this consistently on master
This is a serpapi-ruby bug, not my application code
What's broken?
The constructor accepts String and Symbol keys
(lib/serpapi/client.rb:64), and README.md:88-117 promises that per-call
parameters override defaults. But query at client.rb:290 merges raw
Ruby Hash keys. If the call and default use different key types, both
reach HTTP.rb and are encoded with the same parameter name.
This affects engines, API-key overrides, nil overrides, and arbitrary
backend fields. It also affects image-upload form fields. A default that
should have been replaced is still sent. No particular server-side
precedence for duplicate parameters is assumed.
#29 already handles
this for output, and #37
handles Extract's forced engine. This report concerns ordinary overrides.
It does not include the Hash mutation in #39 or error policy in #42.
How to reproduce
From the repository root, after bundle install. HTTP.rb builds the real
request; perform is intercepted before network I/O:
Activity