Skip to content

Mixed String and Symbol overrides send duplicate parameters #45

Open

Description

@yorzi

Basic checks

  • I searched existing issues, open and closed, and found no general mixed-key override fix
  • I can reproduce this consistently on master
  • This is a serpapi-ruby bug, not my application code

What's broken?

The constructor accepts String and Symbol keys
(lib/serpapi/client.rb:64), and README.md:88-117 promises that per-call
parameters override defaults. But query at client.rb:290 merges raw
Ruby Hash keys. If the call and default use different key types, both
reach HTTP.rb and are encoded with the same parameter name.

This affects engines, API-key overrides, nil overrides, and arbitrary
backend fields. It also affects image-upload form fields. A default that
should have been replaced is still sent. No particular server-side
precedence for duplicate parameters is assumed.

#29 already handles
this for output, and #37
handles Extract's forced engine. This report concerns ordinary overrides.
It does not include the Hash mutation in
#39 or error policy in
#42.

How to reproduce

From the repository root, after bundle install. HTTP.rb builds the real
request; perform is intercepted before network I/O:

bundle exec ruby -Ilib - <<'RUBY'
require 'serpapi'

response = Struct.new(:status, :headers, :body).new(
  200, { 'Content-Type' => 'application/json' }, '{}'
)
transport = HTTP::Client.new
transport.define_singleton_method(:perform) do |request, _options|
  p request.uri.query_values(Array).select { |key, _| key == 'engine' }
  response
end
HTTP.define_singleton_method(:timeout) { |_timeout| transport }
client = SerpApi::Client.new('engine' => 'google', persistent: false)
client.search(engine: 'bing')
RUBY

Expected behavior

[["engine", "bing"]]

What actually happened

[["engine", "google"], ["engine", "bing"]]

I have a small local fix with tests and can open a PR.

Environment

  • Ruby 3.4.4, macOS arm64
  • serpapi-ruby master at 786baa6848020df031abed734ed7ff03af3a6560
  • HTTP.rb 5.3.1, RSpec 3.13.2
  • No API credentials, external requests, or search credits used

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions