build(java): align toolchain and runtime to Java 25 (bytecode 17)#121
Open
cristianrcv wants to merge 3 commits into
Open
build(java): align toolchain and runtime to Java 25 (bytecode 17)#121cristianrcv wants to merge 3 commits into
cristianrcv wants to merge 3 commits into
Conversation
Adopt Java 25 as the build toolchain and runtime (Gradle toolchain and CI workflows) while keeping the language level and bytecode target at Java 17. Follows the proposed org-wide standard in the Java 25 ADR (seqeralabs/adr#48), which supersedes the 2024-12-03 Java 17/21 ADR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Cristian Ramon-Cortes <cristian.ramon-cortes@seqera.io>
Switch the CI setup-java JDK distribution from Temurin to Amazon Corretto, following the Java 25 ADR (seqeralabs/adr#48), which specifies Amazon Corretto as the preferred distribution for Linux. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Cristian Ramon-Cortes <cristian.ramon-cortes@seqera.io>
The Groovy 4.0.24 compiler cannot process Java 25 class files (fails with "Unsupported class file major version 69") when compiling tests on the Java 25 toolchain. Bump to 4.0.31, which supports JDK 25, matching the version used by the nextflow project. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Cristian Ramon-Cortes <cristian.ramon-cortes@seqera.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns wave-cli to the proposed org-wide Java 25 standard (implements https://github.com/seqeralabs/adr/pull/48). Adopts Java 25 as the build toolchain and runtime while keeping the language level and bytecode target at Java 17, so produced artifacts remain Java 17 compatible.
What changed
app/build.gradle: Gradle toolchainJavaLanguageVersion.of(21)->of(25)(mainjavablock and the GraalVMnativeCompilejavaLauncher).sourceCompatibility/targetCompatibilityremain17..github/workflows/build.yml:java-version'21'->'25'in bothsetup-graalvmsteps and the JReleasersetup-javastep..github/workflows/security-submit-dependecy-graph.yml:setup-graalvmjava-version21->25.GraalVM native-image configuration and build args are unchanged.
Why
Follows the proposed org-wide standard in the Java 25 ADR (seqeralabs/adr#48), which supersedes the 2024-12-03 Java 17/21 ADR. Standardizing the toolchain/runtime on Java 25 across repos while keeping bytecode at 17 preserves runtime compatibility.
How to verify
./gradlew assembleand./gradlew checkbuild/test on the Java 25 toolchain.javap -von a compiled class reports major version 61.build.ymlandsecurity-submit-dependecy-graph.ymlprovision Java 25 viasetup-graalvm/setup-java../gradlew app:nativeCompile) runs on the Java 25 launcher.🤖 Generated with Claude Code