build(deps): update openssl-sys to 0.9.117 for OpenSSL 4 support - #144
Open
BenjaminDEMAILLE wants to merge 1 commit into
Open
build(deps): update openssl-sys to 0.9.117 for OpenSSL 4 support#144BenjaminDEMAILLE wants to merge 1 commit into
BenjaminDEMAILLE wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cargo.lockpinsopenssl-sys 0.9.112, which refuses to build against OpenSSL 4:The dependency chain is
rust-htslib→hts-sys→curl-sys→openssl-sys, so anybuild of RustQC with
--lockedon a system whose OpenSSL is 4.x fails at that check.OpenSSL 4 support landed in
openssl-sys 0.9.114; from that release the same code pathreads:
This matters for distributions that have already moved: Homebrew is migrating its
formulae to
openssl@4, and a RustQC formula currently has to pinopenssl@3to build.Change
cargo update -p openssl-sys, which moves0.9.112→0.9.117.Cargo.tomlisuntouched: the bump is within the existing semver range, so this is a lockfile-only
change of two lines.
Verification
Independent of #130, which updates
hts-sys; the two touch different lockfile entriesand can land in either order.