Skip to content

build(deps): update openssl-sys to 0.9.117 for OpenSSL 4 support - #144

Open
BenjaminDEMAILLE wants to merge 1 commit into
seqeralabs:mainfrom
BenjaminDEMAILLE:fix/openssl-sys-lockfile-openssl4
Open

build(deps): update openssl-sys to 0.9.117 for OpenSSL 4 support#144
BenjaminDEMAILLE wants to merge 1 commit into
seqeralabs:mainfrom
BenjaminDEMAILLE:fix/openssl-sys-lockfile-openssl4

Conversation

@BenjaminDEMAILLE

Copy link
Copy Markdown

Problem

Cargo.lock pins openssl-sys 0.9.112, which refuses to build against OpenSSL 4:

// openssl-sys-0.9.112/build/main.rs:439
if openssl_version >= 0x4_00_00_00_0 {
    version_error()   // panic!("... no supported version of OpenSSL found ...")
}

The dependency chain is rust-htslibhts-syscurl-sysopenssl-sys, so any
build of RustQC with --locked on a system whose OpenSSL is 4.x fails at that check.

OpenSSL 4 support landed in openssl-sys 0.9.114; from that release the same code path
reads:

// openssl-sys-0.9.117/build/main.rs:444
if openssl_version >= 0x5_00_00_00_0 {
    version_error()
} else if openssl_version >= 0x4_00_00_00_0 {
    Version::Openssl4xx
}

This matters for distributions that have already moved: Homebrew is migrating its
formulae to openssl@4, and a RustQC formula currently has to pin openssl@3 to build.

Change

cargo update -p openssl-sys, which moves 0.9.1120.9.117. Cargo.toml is
untouched: the bump is within the existing semver range, so this is a lockfile-only
change of two lines.

Verification

cargo build --release --locked     # ok
cargo test  --release --locked     # 232 passed, 0 failed

Independent of #130, which updates hts-sys; the two touch different lockfile entries
and can land in either order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant