Skip to content
This repository was archived by the owner on Feb 10, 2022. It is now read-only.

Commit 835a50d

Browse files
committed
Merge branch 'feature/calls-700' of https://github.com/sendbird/quickstart-calls-javascript-dev into feature/calls-700
2 parents 1f00f8f + 31efa8a commit 835a50d

File tree

2 files changed

+24
-27
lines changed

2 files changed

+24
-27
lines changed

lib/utils/domUtil.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ export function replaceClassName(element, searchValue, newValue) {
141141
}
142142

143143
export function hasClassName(element, searchValue) {
144-
if(element.classList.value.indexOf(searchValue) === -1) {
144+
return (element.classList.value.indexOf(searchValue) !== -1);
145145
return false;
146146
}
147147
return true;
148-
}
148+
}

lib/views/CallLogView.js

Lines changed: 22 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -47,31 +47,28 @@ export default class CallLogView extends BaseElement{
4747
}
4848

4949
getCallLogs(element){
50-
if(this.callLogQuery.hasNext && !this.callLogQuery.isLoading) {
51-
this.callLogQuery.next((directCallLog) => {
52-
if(directCallLog){
53-
if(directCallLog.length > 0) {
54-
for( let i = 0; i < directCallLog.length; i++ ){
55-
let callItem = null;
56-
if(i === 0){
57-
callItem = new CallLogItem({ callLogInfo: directCallLog[i], className: `${classes['callLogItemWrap']}` });
58-
} else {
59-
callItem = new CallLogItem({ callLogInfo: directCallLog[i], className: `${classes['callLogItemWrap']} ${classes['callLogItemWarpBorder']}` });
60-
}
61-
callItem.onclick = (event, args) => {
62-
this.sendToParent('dial', args);
63-
};
64-
65-
element.appendChild(callItem.element);
66-
}
67-
}
68-
else{
69-
// empty call log
70-
const emptyCallLog = new CallLogItem({ className: `${classes['callLogEmptyWrap']}` });
71-
element.appendChild(emptyCallLog.element);
50+
if (!this.callLogQuery.hasNext || this.callLogQuery.isLoading) return;
51+
this.callLogQuery.next((directCallLog) => {
52+
if( directCallLog.length > 0 ) {
53+
for( let i = 0; i < directCallLog.length; i++ ){
54+
let callItem = null;
55+
if(i === 0){
56+
callItem = new CallLogItem({ callLogInfo: directCallLog[i], className: `${classes['callLogItemWrap']}` });
57+
} else {
58+
callItem = new CallLogItem({ callLogInfo: directCallLog[i], className: `${classes['callLogItemWrap']} ${classes['callLogItemWarpBorder']}` });
7259
}
60+
callItem.onclick = (event, args) => {
61+
this.sendToParent('dial', args);
62+
};
63+
64+
element.appendChild(callItem.element);
7365
}
74-
});
75-
}
66+
}
67+
else{
68+
// empty call log
69+
const emptyCallLog = new CallLogItem({ className: `${classes['callLogEmptyWrap']}` });
70+
element.appendChild(emptyCallLog.element);
71+
}
72+
});
7673
}
77-
}
74+
}

0 commit comments

Comments
 (0)