Skip to content
This repository was archived by the owner on Feb 10, 2022. It is now read-only.

Commit 1f00f8f

Browse files
committed
[CALLS-700]Call history design implementation
review apply
1 parent 7950924 commit 1f00f8f

File tree

6 files changed

+16
-19
lines changed

6 files changed

+16
-19
lines changed

lib/components/App.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ export default class App extends BaseElement {
3030
route(pageName, opt = {}) {
3131
for (let i = this.children.length - 1 ; i >= 0 ; i--) {
3232
const child = this.children[i];
33-
if( child.element.id === 'header' || child.element.id === 'tabtoolbar') {
34-
if( opt.isRemoveHeader === true ) {
33+
if(child.element.id === 'header' || child.element.id === 'tabtoolbar') {
34+
if(opt.isRemoveHeader === true) {
3535
child.remove();
3636
}
3737
}

lib/components/Header.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export default class Header extends BaseElement {
8888
this.element.appendChild(divider);
8989
this.element.appendChild(headerButtons);
9090

91-
if( !this.args.isWidget ){
91+
if(!this.args.isWidget){
9292
const headerLogo = createDiv({ id: 'header_logo', className: `${classes['headerLogo']}`});
9393
this.element.appendChild(headerLogo);
9494
}

lib/components/TabToolBar.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export default class TabToolBar extends BaseElement {
1111

1212
build() {
1313
// dial tab
14-
if( this.args.isWidget ) {
14+
if(this.args.isWidget) {
1515
this.element.classList.add(classes['tabToolBarWidget']);
1616
}
1717
const btnDial = createDiv({ id: 'btn_tab_dial', className: `${classes['btnTab']}` });
@@ -32,7 +32,7 @@ export default class TabToolBar extends BaseElement {
3232
}
3333
};
3434

35-
if( this.args.isWidget ) {
35+
if(this.args.isWidget) {
3636
btnDial.classList.add(classes['btnTabWidget']);
3737
}
3838

@@ -55,7 +55,7 @@ export default class TabToolBar extends BaseElement {
5555
}
5656
};
5757

58-
if( this.args.isWidget ) {
58+
if(this.args.isWidget) {
5959
btnCallLog.classList.add(classes['btnTabWidget']);
6060
}
6161

lib/css/styles.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,6 @@ const styles = {
11091109
callLogListContainer: {
11101110
display: 'inline-block',
11111111
position: 'relative',
1112-
height: 'calc(100% - 103px)',
11131112
height: '100%',
11141113
overflowY: 'auto',
11151114
listStyle: 'none',

lib/views/CallLogItem.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,14 @@ export class CallLogItem {
5858
let hour = parseInt(tempDuration / 3600);
5959
let min = parseInt((tempDuration - (hour * 3600)) / 60);
6060
let sec = tempDuration - (hour * 3600) - (min * 60);
61-
if( hour > 0 ){
61+
if(hour > 0){
6262
callDurationTime = hour + 'h ';
6363
}
64-
if( min > 0 ){
64+
if(min > 0){
6565
callDurationTime += (min + 'm ');
6666
}
6767
callDurationTime += (sec + 's');
68-
}
69-
else {
68+
} else {
7069
callDurationTime = '0s';
7170
}
7271

lib/views/CallLogView.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ export default class CallLogView extends BaseElement{
2323
this.getCallLogs(callLogList);
2424
callLogList.onscroll = (e) => {
2525
let scrollposition = e.target.scrollHeight - e.target.clientHeight;
26-
if( scrollposition === e.target.scrollTop ) {
26+
if(scrollposition === e.target.scrollTop) {
2727
this.getCallLogs(callLogList);
2828
}
2929
};
3030

31-
if( this.args.isWidget ) {
31+
if(this.args.isWidget) {
3232
callLogList.classList.add(classes['widgetCallLog']);
3333
this.element.appendChild(callLogList);
3434
}
@@ -47,16 +47,15 @@ export default class CallLogView extends BaseElement{
4747
}
4848

4949
getCallLogs(element){
50-
if( this.callLogQuery.hasNext && !this.callLogQuery.isLoading ) {
50+
if(this.callLogQuery.hasNext && !this.callLogQuery.isLoading) {
5151
this.callLogQuery.next((directCallLog) => {
52-
if( directCallLog ){
53-
if( directCallLog.length > 0 ) {
52+
if(directCallLog){
53+
if(directCallLog.length > 0) {
5454
for( let i = 0; i < directCallLog.length; i++ ){
5555
let callItem = null;
56-
if( i === 0 ){
56+
if(i === 0){
5757
callItem = new CallLogItem({ callLogInfo: directCallLog[i], className: `${classes['callLogItemWrap']}` });
58-
}
59-
else {
58+
} else {
6059
callItem = new CallLogItem({ callLogInfo: directCallLog[i], className: `${classes['callLogItemWrap']} ${classes['callLogItemWarpBorder']}` });
6160
}
6261
callItem.onclick = (event, args) => {

0 commit comments

Comments
 (0)