-
Notifications
You must be signed in to change notification settings - Fork 21
docs+fix: update documentation and API responses for post-0.3.0 changes #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bburda
wants to merge
10
commits into
main
Choose a base branch
from
docs/update-post-0.3.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
61d383c
docs(tutorials): fix manifest-discovery param names and unmanifested_…
bburda d92875c
docs(config): add Logging and Rate Limiting sections to server reference
bburda 1422a1c
docs(config): add merge pipeline reference to discovery options
bburda 8fb76eb
docs(api): update server capabilities example response
bburda 0f089c8
docs(tutorials): update plugin system - IntrospectionProvider wired, …
bburda 68b3f93
fix(api): complete handle_root endpoint/capability list, fix version-…
bburda 5047321
fix: address PR #258 review comments and CI failure
bburda 80091bc
fix: address self-review findings
bburda 49f8d80
fix(discovery): prevent topic components leaking in manifest_only mode
bburda 94818bb
test: rename SovdEntry tests to ItemsEntry, add manifest_only regress…
bburda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This health endpoint example doesn’t match the current
/api/v1/healthresponse. In code,discovery.strategyis the strategy name string (e.g."hybrid"), anddiscovery.pipelineisMergeReport::to_json()(keys likelayers,total_entities,enriched_count,conflicts,id_collisions,filtered_by_gap_fill)—it does not include anentity_sourcemap. Please update the example to reflect the actual JSON fields returned byHealthHandlers::handle_health()/MergeReport::to_json().There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 80091bc - health endpoint example now matches
MergeReport::to_json()output:total_entities,enriched_count,conflict_count,conflicts,id_collisions,filtered_by_gap_fill. Strategy name corrected to"hybrid".