Skip to content

Fix high rate of cancelled AI review jobs - #67

Merged
masih merged 1 commit into
mainfrom
masih/reduce-cancellation
Aug 25, 2026
Merged

Fix high rate of cancelled AI review jobs#67
masih merged 1 commit into
mainfrom
masih/reduce-cancellation

Conversation

@masih

@masih masih commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Check review comment in AI review job to avid high cancellation rate upstream.

Check review comment in AI review job to avid high cancellation rate upstream.
@masih
masih marked this pull request as ready for review August 25, 2026 09:16
@cursor

cursor Bot commented Aug 25, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CI workflow condition only; no application code, auth, or data handling changes.

Overview
Fixes the preflight job gate for pull_request_review events so trigger detection reads github.event.review.body instead of github.event.comment.body.

On a submitted PR review, the trigger phrase and review keyword live on the review object, not a comment. The wrong field meant explicit @seidroid review requests via Submit review often failed the preflight if, so downstream jobs did not run or behaved inconsistently—matching the reported high rate of cancelled AI review runs.

The resolve step already parsed review.body correctly; this aligns the job-level filter with that logic.

Reviewed by Cursor Bugbot for commit a568c03. Bugbot is set up for automated code reviews on this repo. Configure here.

@seidroid seidroid Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two-line fix in .github/workflows/ai-review.yml that makes the pull_request_review branch of the preflight if: read github.event.review.body instead of the non-existent github.event.comment.body. The corrected expression now matches how the downstream resolve step already extracts the body/actor for review events, and the caller restricts pull_request_review to submitted, so the trigger path behaves as documented.

Findings: 0 blocking | 0 non-blocking | 0 posted inline

Blockers

  • None at the file/PR level.

Non-blocking

  • None at the file/PR level.

@masih
masih merged commit a4b7a32 into main Aug 25, 2026
11 of 15 checks passed
@masih
masih deleted the masih/reduce-cancellation branch August 25, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant