Conversation
…e rollouts) Pulls in #216 — NodeUpdate plans now include a `replace-pod` task that proactively deletes pods at the old StatefulSet revision. StatefulSets generated by this controller now use OnDelete update strategy, so pod lifecycle is the SeiNode controller's responsibility (replace-pod). This unblocks the chain-upgrade rollout pattern where seid is intentionally unready (halted at upgrade height) and native RollingUpdate refuses to disturb it. Closes #211. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace-podtask that proactively deletes pods at the old StatefulSet revision.OnDeleteupdate strategy (pod lifecycle is the SeiNode controller's responsibility, not the StatefulSet controller's).seidis intentionally unready (halted at upgrade height) and nativeRollingUpdaterefuses to disturb the unready pod.Closes #211 once this lands and rolls out.
Rollback semantics
OnDeleteis set in the StatefulSet spec (internal/noderesource/), so reverting the controller container alone won't flip the strategy back — existing StatefulSets stay onOnDelete. To fully revert, also delete and recreate the affected SeiNode resources, or hand-patch the StatefulSet spec.Test plan
apply-statefulset→apply-service→replace-pod→observe-image→mark-readyreplace-podand StatefulSet recreates it at the new revisionspec.image == status.currentImageNote
Low Risk
Low risk manifest-only change, but it will roll out a new controller binary; any behavior change depends entirely on the new image contents.
Overview
Updates the controller-manager Deployment (
config/manager/manager.yaml) to use a newsei-k8s-controllerimage tag (069a866…→e99c04c…).Reviewed by Cursor Bugbot for commit d4d1e52. Bugbot is set up for automated code reviews on this repo. Configure here.