Reject native multisig transaction simulation - #4037
Closed
masih wants to merge 1 commit into
Closed
Conversation
Reject multisig keys and signature data during gas simulation while leaving normal transaction execution and single-signature simulation unchanged. Part of SIP-3
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4037 +/- ##
==========================================
- Coverage 61.24% 60.25% -1.00%
==========================================
Files 2153 2054 -99
Lines 188393 176718 -11675
==========================================
- Hits 115387 106477 -8910
+ Misses 62274 60477 -1797
+ Partials 10732 9764 -968
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject multisig keys and signature data during gas simulation while
leaving normal transaction execution and single-signature simulation unchanged.
Part of SIP-3