-
Notifications
You must be signed in to change notification settings - Fork 886
PLT-1072: Wire rate limiter into native gRPC (:9090) unary+stream interceptors #4021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amir-deris
wants to merge
1
commit into
main
Choose a base branch
from
amir/plt-1072-rate-limiter-grpc-interceptors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package grpc | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "google.golang.org/grpc" | ||
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
|
|
||
| "github.com/sei-protocol/sei-chain/ratelimiter" | ||
| ) | ||
|
|
||
| var errRateLimited = status.Error(codes.ResourceExhausted, "too many requests") | ||
|
|
||
| // UnaryRateLimitInterceptor returns a server interceptor that applies per-IP | ||
| // token-bucket rate limiting before the handler runs. registry must be non-nil. | ||
| func UnaryRateLimitInterceptor(registry *ratelimiter.Registry) grpc.UnaryServerInterceptor { | ||
| return func(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) { | ||
| ip := registry.IPFromGRPCContext(ctx) | ||
| if !registry.Allow(ctx, ip, ratelimiter.PlaneGRPC, info.FullMethod) { | ||
| return nil, errRateLimited | ||
| } | ||
| return handler(ctx, req) | ||
| } | ||
| } | ||
|
|
||
| // StreamRateLimitInterceptor returns a server interceptor that applies per-IP | ||
| // token-bucket rate limiting when a client stream is established. registry must | ||
| // be non-nil. | ||
| func StreamRateLimitInterceptor(registry *ratelimiter.Registry) grpc.StreamServerInterceptor { | ||
| return func(srv interface{}, ss grpc.ServerStream, info *grpc.StreamServerInfo, handler grpc.StreamHandler) error { | ||
| ctx := ss.Context() | ||
| ip := registry.IPFromGRPCContext(ctx) | ||
| if !registry.Allow(ctx, ip, ratelimiter.PlaneGRPC, info.FullMethod) { | ||
| return errRateLimited | ||
| } | ||
| return handler(srv, ss) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion] The summary line was updated to "four" but the body below it still carries the old counts: line 1363-1364 says "only three keys are rows. Eight others are read behind v.IsSet", which is now four rows and eleven others.
grpcKeysWithTargetsOfTheirOwn's godoc (line 1398) has the same drift — "Six are read behind v.IsSet ... The other two" is now nine and two, sinceip-rate-limit-rps,ip-rate-limit-burst, andtrusted-proxy-cidrsare allv.IsSet-guarded.This suite is the repo's record of how configuration resolves, and its counts are what a reader checks the tables against, so the stale numbers actively mislead.