Skip to content

Remove stale ibc from v6.7 module version map - #4016

Merged
masih merged 2 commits into
mainfrom
masih/missed-cleanup
Aug 26, 2026
Merged

Remove stale ibc from v6.7 module version map#4016
masih merged 2 commits into
mainfrom
masih/missed-cleanup

Conversation

@masih

@masih masih commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Remove stale IBC from v6.7 module version map and apply minor cleanups
that are missed in previous IBC removal.

Remove obsolete relayer tests.

Remove stale IBC from v6.7 module version map and apply minor cleanups
that are missed in previous IBC removal.

Remove obsolete relayer tests.
@masih
masih marked this pull request as ready for review August 26, 2026 08:55
@cursor

cursor Bot commented Aug 26, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
The v6.7 upgrade path now mutates the module version map for IBC; incorrect handling could affect migrations or upgrade bookkeeping, though on-chain IBC stores stay mounted for compatibility.

Overview
Completes v6.7 IBC retirement cleanup by removing the stale ibc module version from the upgrade keeper’s version map on the v6.7 upgrade (alongside capability, feegrant, and transfer), with tests that seed and assert removal of storekeys.IBCStoreKey.

Documentation and operator guidance add an IBC core removal note to the changelog upgrade guide, link IBC retirement from the README, and document retained CosmWasm port metadata, unsupported IBC ops, and mounted stores in docs/ibc_retirement.md.

Miscellaneous cleanup deletes obsolete sei-wasmd/contrib/relayer-tests, reserves CosmWasm error code 16 without exporting ErrMaxIBCChannels, and clarifies in mod_test.go that github.com/cosmos/ibc-go is banned because IBC is retired rather than forked locally.

Reviewed by Cursor Bugbot for commit 0fad251. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedAug 26, 2026, 9:08 AM

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.30%. Comparing base (9c5bb15) to head (0fad251).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4016      +/-   ##
==========================================
- Coverage   61.31%   60.30%   -1.01%     
==========================================
  Files        2158     2059      -99     
  Lines      188203   176609   -11594     
==========================================
- Hits       115395   106508    -8887     
+ Misses      62162    60394    -1768     
+ Partials    10646     9707     -939     
Flag Coverage Δ
sei-chain-pr 58.20% <100.00%> (?)
sei-db 69.80% <ø> (ø)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/upgrades.go 46.29% <100.00%> (+1.01%) ⬆️
sei-wasmd/x/wasm/types/errors.go 0.00% <ø> (ø)

... and 99 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@seidroid seidroid Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-scoped cleanup: deleting the stale ibc module version at the v6.7 upgrade is correct and covered by a test, and the new IBC retirement doc's claims match the actual CosmWasm query/message behavior. Two non-blocking documentation/convention nits.

Findings: 0 blocking | 2 non-blocking | 2 posted inline

Blockers

  • None at the file/PR level.

Non-blocking

  • None at the file/PR level.
  • 2 suggestion(s)/nit(s) flagged inline on specific lines.

Comment thread sei-wasmd/x/wasm/types/errors.go
Comment thread docs/ibc_retirement.md Outdated
@masih

masih commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

@seidroid review

@seidroid seidroid Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, well-scoped follow-up: the stale ibc module version is deleted at the v6.7 upgrade with matching test coverage, wasm error code 16 is now reserved per the file's existing convention, and the removed relayer scripts/doc updates are consistent with the IBC retirement. One carry-over documentation inaccuracy remains in the CHANGELOG upgrade guide.

Findings: 0 blocking | 1 non-blocking | 1 posted inline

Blockers

  • None at the file/PR level.

Non-blocking

  • None at the file/PR level.
  • 1 suggestion(s)/nit(s) flagged inline on specific lines.

Comment thread CHANGELOG.md
* [#3990](https://github.com/sei-protocol/sei-chain/pull/3990) Freeze mode is limited to full nodes and disables transaction and evidence submission, mempool gossip, and state sync from startup while preserving query RPC and mempool-backed reads. Frozen and Autobahn nodes no longer advertise the unused mempool P2P channel.

### Upgrade guide
* **IBC core removal.** Removes the retired IBC core source, protobufs, light clients, CLI, and simulation support. Retired IBC stores remain mounted but are omitted from `export-genesis`; preserve the state database or use v6.6 freeze nodes for historical IBC data.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] export-genesis is not a command in this repo. The CLI is seid export (sei-cosmos/server/export.go:41, registered via ExportCmd in sei-cosmos/server/util.go:369), backed by App.ExportAppStateAndValidators. The substance is correct — the retired modules are no longer in the module manager, so their state is not exported — but an operator following this upgrade guide will get an unknown-command error. The identical string was removed from docs/ibc_retirement.md; this copy was missed.

@masih
masih added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit 6642e1e Aug 26, 2026
77 checks passed
@masih
masih deleted the masih/missed-cleanup branch August 26, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants