Remove stale ibc from v6.7 module version map - #4016
Conversation
Remove stale IBC from v6.7 module version map and apply minor cleanups that are missed in previous IBC removal. Remove obsolete relayer tests.
PR SummaryMedium Risk Overview Documentation and operator guidance add an IBC core removal note to the changelog upgrade guide, link IBC retirement from the README, and document retained CosmWasm port metadata, unsupported IBC ops, and mounted stores in Miscellaneous cleanup deletes obsolete Reviewed by Cursor Bugbot for commit 0fad251. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4016 +/- ##
==========================================
- Coverage 61.31% 60.30% -1.01%
==========================================
Files 2158 2059 -99
Lines 188203 176609 -11594
==========================================
- Hits 115395 106508 -8887
+ Misses 62162 60394 -1768
+ Partials 10646 9707 -939
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Well-scoped cleanup: deleting the stale ibc module version at the v6.7 upgrade is correct and covered by a test, and the new IBC retirement doc's claims match the actual CosmWasm query/message behavior. Two non-blocking documentation/convention nits.
Findings: 0 blocking | 2 non-blocking | 2 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- None at the file/PR level.
- 2 suggestion(s)/nit(s) flagged inline on specific lines.
|
@seidroid review |
There was a problem hiding this comment.
Correct, well-scoped follow-up: the stale ibc module version is deleted at the v6.7 upgrade with matching test coverage, wasm error code 16 is now reserved per the file's existing convention, and the removed relayer scripts/doc updates are consistent with the IBC retirement. One carry-over documentation inaccuracy remains in the CHANGELOG upgrade guide.
Findings: 0 blocking | 1 non-blocking | 1 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- None at the file/PR level.
- 1 suggestion(s)/nit(s) flagged inline on specific lines.
| * [#3990](https://github.com/sei-protocol/sei-chain/pull/3990) Freeze mode is limited to full nodes and disables transaction and evidence submission, mempool gossip, and state sync from startup while preserving query RPC and mempool-backed reads. Frozen and Autobahn nodes no longer advertise the unused mempool P2P channel. | ||
|
|
||
| ### Upgrade guide | ||
| * **IBC core removal.** Removes the retired IBC core source, protobufs, light clients, CLI, and simulation support. Retired IBC stores remain mounted but are omitted from `export-genesis`; preserve the state database or use v6.6 freeze nodes for historical IBC data. |
There was a problem hiding this comment.
[suggestion] export-genesis is not a command in this repo. The CLI is seid export (sei-cosmos/server/export.go:41, registered via ExportCmd in sei-cosmos/server/util.go:369), backed by App.ExportAppStateAndValidators. The substance is correct — the retired modules are no longer in the module manager, so their state is not exported — but an operator following this upgrade guide will get an unknown-command error. The identical string was removed from docs/ibc_retirement.md; this copy was missed.
Remove stale IBC from v6.7 module version map and apply minor cleanups
that are missed in previous IBC removal.
Remove obsolete relayer tests.