Replace hardcoded ~/go/bin/seid path with seid in scripts#2996
Open
yzhanginwa wants to merge 1 commit intosei-protocol:mainfrom
Open
Replace hardcoded ~/go/bin/seid path with seid in scripts#2996yzhanginwa wants to merge 1 commit intosei-protocol:mainfrom
yzhanginwa wants to merge 1 commit intosei-protocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
The "
/go/bin/seid" is used in the 2 files scripts/benchmark.sh and scripts/initialize_local_chain.sh. It caused problem/go/bin". For example, I'm a mise user, my local GOBIN is like "~/.local/share/mise/installs/go/1.25.6/bin/go". It's still better to respect the $PATH instead of using hard coded path.for uses whose GOBIN is not the default "
Testing performed to validate your change
I tested both scripts benchmark.sh and initialize_local_chain.sh successfully.