Prevent JSON queue file growth over 512 KB #188
+274
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelGHSeg
reviewed
Nov 7, 2025
| buffer = utf8.encode(serialized); | ||
|
|
||
| // If still too big after trimming to target, write empty queue as last resort | ||
| if (buffer.length > _kMaxQueueBytes) { |
Contributor
There was a problem hiding this comment.
Looks good, just want double check with @bsneed on this logic to empty the queue. Max individual event size is 32k if I remember correctly which is less than the difference in max size and the 475k target, so this seems ok to me as a probably-never-happen last ditch case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proactive size checks so the SDK avoids queuing events that would push the on-disk queue file above 512 KB. When a new event would exceed the limit, the plugin attempts an immediate flush instead of silently trimming. Keep a safe trimming/fallback path on write failures or unexpected edge cases.