Normalise Events type filters#10
Closed
d180 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalise the Events type filter before applying the store query so
llmandtoolmap to the storedEVENT_TYPE_LLMandEVENT_TYPE_TOOLvalues.This fixes the dashboard behaviour where selecting
LLMorToolcould hide matching events because the frontend filter values did not match the exact values stored inevents.event_type.Closes #9
Test plan
docker run --rm -v "$PWD":/src -w /src/backend golang:1.25-bookworm go test ./internal/storeChecklist