Skip to content

Conversation

@clairem-sl
Copy link

Description

  1. Fix the chopped error message
  2. Make color escape sequence adapt to $TERM
  3. Add NOBACKUP option

Related Issues


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

To invoke the NOBACKUP option, just specify the word as an argument to the install script. For example:

# Non-root installation
./install.sh NOBACKUP

# Root installation
sudo ./install.sh NOBACKUP

If tput doesn't exist, that means probably colors aren't supported anyways, so we'll just skip setting the colorizing env vars
In die(), if $1 is not quoted, then only the first word will be passed to warn().

In warn(), not only we quote $1, we also add -e to allow embedded escaped characters such as "\n"
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@clairem-sl clairem-sl changed the title Fix & improve installsh Fix & improve install.sh Jan 2, 2026
@clairem-sl
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant