Skip to content

tests: patch localtime in the "cert remainingdays" test#4956

Merged
gpotter2 merged 1 commit intosecdev:masterfrom
evverx:rem-days-test
Mar 30, 2026
Merged

tests: patch localtime in the "cert remainingdays" test#4956
gpotter2 merged 1 commit intosecdev:masterfrom
evverx:rem-days-test

Conversation

@evverx
Copy link
Copy Markdown
Contributor

@evverx evverx commented Mar 29, 2026

to make sure the code where the invalid timezone is passed to exercise the localtime code path doesn't fail as time goes by.

The other test was added to exercise the code path where the second format is passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.30%. Comparing base (2b220b9) to head (144112b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4956       +/-   ##
===========================================
+ Coverage   47.61%   80.30%   +32.69%     
===========================================
  Files         361      379       +18     
  Lines       92766    93107      +341     
===========================================
+ Hits        44170    74772    +30602     
+ Misses      48596    18335    -30261     

see 332 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

to make sure the code where the invalid timezone is passed to exercise
the localtime code path doesn't fail as time goes by.

The other test was added to exercise the code path where the second
format is passed.
@evverx evverx marked this pull request as draft March 30, 2026 05:13
Copy link
Copy Markdown
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's merge it asap to unblock downstream.

@gpotter2
Copy link
Copy Markdown
Member

Thanks !

@gpotter2 gpotter2 marked this pull request as ready for review March 30, 2026 09:23
@gpotter2 gpotter2 merged commit f4a2ca4 into secdev:master Mar 30, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants