BUG: check direct syscall before multiplexed pseudo-syscall#488
Open
nikita-dubrovskii wants to merge 1 commit into
Open
BUG: check direct syscall before multiplexed pseudo-syscall#488nikita-dubrovskii wants to merge 1 commit into
nikita-dubrovskii wants to merge 1 commit into
Conversation
Docker 29.4.2 removed socketcall(2) from the default seccomp profile. On s390x, this broke socket operations: # strace curl icanhazip.com socket(AF_UNIX, SOCK_STREAM, 0) = -1 ENOSYS (Function not implemented) # scmp_sys_resolver -a s390x socket -101 # ausyscall s390x socket socket 359 The abi_syscall_resolve_name_munge() function was returning __PNR_socket (-101) instead of checking if arch implements socket(2) directly (359). Fix by checking arch->syscall_resolve_name_raw() first, only falling back to multiplexed pseudo-syscalls if the direct implementation doesn't exist. Affects socket and IPC syscalls on architectures with direct implementations (s390x, aarch64, etc). Signed-off-by: Nikita Dubrovskii <nikita@linux.ibm.com>
Author
|
This won't fix Docker itself, but at least the tools will return the correct values: |
Member
|
We need to be careful with changes like this as it is changing the behavior of the library in a way that might not be friendly to all of the users. |
Member
|
Marking this as a BUG for now, but until we understand the impact of a change like this we need to take the classification with a grain of salt ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker 29.4.2 removed socketcall(2) from the default seccomp profile. On s390x, this broke socket operations:
The abi_syscall_resolve_name_munge() function was returning __PNR_socket (-101) instead of checking if arch implements socket(2) directly (359).
Fix by checking arch->syscall_resolve_name_raw() first, only falling back to multiplexed pseudo-syscalls if the direct implementation doesn't exist.
Affects socket and IPC syscalls on architectures with direct implementations (s390x, aarch64, etc).