fix: enforce UTF-8 encoding for file output#93
Closed
etnperlong wants to merge 1 commit intosebaubuntu-python:masterfrom
Closed
fix: enforce UTF-8 encoding for file output#93etnperlong wants to merge 1 commit intosebaubuntu-python:masterfrom
etnperlong wants to merge 1 commit intosebaubuntu-python:masterfrom
Conversation
Specify explicitly `encoding="utf-8"` when writing files to prevent `UnicodeEncodeError` on systems with non-UTF-8 default locales. This issue was triggered when processing firmware properties containing non-ASCII characters.
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a UnicodeEncodeError that occurs when processing firmware dumps containing non-ASCII characters in build properties, especially on systems where the default locale encoding is not UTF-8.
Problem
When processing certain Chinese ROMs (e.g., TB375FC_CN), the tool crashes during the proprietary files list generation or build properties dumping phase:
Traceback (most recent call last):
This is because the file is opened using the environment's default encoding (often ASCII), which cannot handle the Unicode characters present in the build properties.
Solution
Ensured that all text-based file writing operations explicitly use UTF-8 encoding:
Verification
The fix has been verified to correctly process ROMs that previously caused the crash.