Skip to content

Commit df9d93c

Browse files
authored
Apply suggestions from code review
Co-authored-by: Evan Sosenko <razorx@evansosenko.com>
1 parent da8f2f6 commit df9d93c

2 files changed

Lines changed: 1 addition & 15 deletions

File tree

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ The Seam API tells an omitted param apart from one explicitly set to null.
289289
In an update request, an omitted param leaves the current value unchanged,
290290
while a null param unsets it.
291291

292-
Python has a single absence value, so this SDK spells the two apart.
292+
Python has a single nil value `None` which represents an undefined parameter. This SDK provides an explicit null value to send in requests.
293293
A param set to ``None`` is omitted, and a param set to ``NULL`` is sent as null:
294294

295295
.. code-block:: python

seam/client.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -152,20 +152,6 @@ def _handle_error_response(self, response: Response):
152152

153153

154154
def with_search_params(url: Any, params: Mapping[str, Any]) -> Any:
155-
"""Returns the url with the params serialized into its query string.
156-
157-
The Seam API parses URL search params as complex types, so the query
158-
string is built here and set on the url as-is. Handing the params to
159-
httpx instead would encode them with its own rules.
160-
161-
:param url: The url of the request
162-
:type url: Any
163-
164-
:param params: The search params of the request
165-
:type params: Mapping[str, Any]
166-
167-
:returns: The url carrying the serialized params"""
168-
169155
query = serialize_url_search_params(params)
170156

171157
if not query:

0 commit comments

Comments
 (0)