libmicrokit: add microkit_vcpu_x86_deferred_resume() call#431
Open
dreamliner787-9 wants to merge 3 commits intoseL4:mainfrom
Open
libmicrokit: add microkit_vcpu_x86_deferred_resume() call#431dreamliner787-9 wants to merge 3 commits intoseL4:mainfrom
microkit_vcpu_x86_deferred_resume() call#431dreamliner787-9 wants to merge 3 commits intoseL4:mainfrom
Conversation
Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
dreamliner787-9
force-pushed
the
x86_vcpu_resume
branch
from
eaecb0d to
a0cf31f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on seL4/seL4#1534, I've worked around this for now by including
vmenter.hinlibmicrokit/include/microkit.h.Previously, the Microkit event handler had no mechanism on x86 to resume a vCPU while simultaneously waiting for an incoming notification. This PR adds
microkit_vcpu_x86_deferred_resume()to libmicrokit, providing a cleaner way to integrate x86 vCPU resumption with the Microkit event handler.Due to a kernel limitation in
void NORETURN slowpath(syscall_t syscall)ofsrc/arch/x86/c_traps.c, only the VMM's TCB bound Notification is checked for a pending Notification. An endpoint object can't passed toseL4_VMEnter()so PPCs won't work while the VCPU is running. Technically, PPCs still work if the VCPU isn't resumed, but I feel like we should not expose this footgun to users.