Skip to content

SDV 2.0: Update metadata auto-detection to the new V2 format - #2975

Open
R-Palazzo wants to merge 6 commits into
v2.0.0from
issue-2957-update-metadata-autodetection
Open

SDV 2.0: Update metadata auto-detection to the new V2 format#2975
R-Palazzo wants to merge 6 commits into
v2.0.0from
issue-2957-update-metadata-autodetection

Conversation

@R-Palazzo

@R-Palazzo R-Palazzo commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Resolve #2957
86bbgka4c

Here are a few points I wanted to check:

  1. My assumption was that we should not detect ranges for columns with the unknown sdtype. Does that make sense?

  2. I created two test utility methods to make the metadata assertions easier to maintain, since the new range keys make the expected metadata much larger (range_values especially) and hardcoding all the values did not seem ideal:

    • compare_metadata(metadata, expected_metadata) checks that the existing metadata detection behavior is preserved and validates the expected metadata keys.
    • compare_ranges(metadata, data) validates the detected range values against the original data.

@R-Palazzo R-Palazzo self-assigned this Sep 3, 2026
@R-Palazzo
R-Palazzo requested a review from a team as a code owner September 3, 2026 14:57
@sdv-team

sdv-team commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.90%. Comparing base (9e23c92) to head (90dc32c).

Additional details and impacted files
@@            Coverage Diff             @@
##           v2.0.0    #2975      +/-   ##
==========================================
+ Coverage   97.89%   97.90%   +0.01%     
==========================================
  Files          66       66              
  Lines        7684     7746      +62     
==========================================
+ Hits         7522     7584      +62     
  Misses        162      162              
Flag Coverage Δ
integration 84.34% <98.80%> (+0.37%) ⬆️
unit 96.26% <98.80%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sdv-team

sdv-team commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

Base automatically changed from fix-output_folder_path to v2.0.0 September 4, 2026 09:10
@R-Palazzo
R-Palazzo force-pushed the issue-2957-update-metadata-autodetection branch from 593a15e to b5486d6 Compare September 7, 2026 10:37
@sdv-team

sdv-team commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@sdv-team

Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants