SDV 2.0: Update metadata auto-detection to the new V2 format - #2975
SDV 2.0: Update metadata auto-detection to the new V2 format#2975R-Palazzo wants to merge 6 commits into
Conversation
|
This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2.0.0 #2975 +/- ##
==========================================
+ Coverage 97.89% 97.90% +0.01%
==========================================
Files 66 66
Lines 7684 7746 +62
==========================================
+ Hits 7522 7584 +62
Misses 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR! |
593a15e to
b5486d6
Compare
|
This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR! |
|
This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR! |
Resolve #2957
86bbgka4c
Here are a few points I wanted to check:
My assumption was that we should not detect ranges for columns with the
unknownsdtype. Does that make sense?I created two test utility methods to make the metadata assertions easier to maintain, since the new range keys make the expected metadata much larger (
range_valuesespecially) and hardcoding all the values did not seem ideal:compare_metadata(metadata, expected_metadata)checks that the existing metadata detection behavior is preserved and validates the expected metadata keys.compare_ranges(metadata, data)validates the detected range values against the original data.