Add constraint validity property - #936
Open
sarahmish wants to merge 5 commits into
Open
Conversation
sarahmish
requested review from
R-Palazzo and
frances-h
and removed request for
a team
September 10, 2026 19:57
sarahmish
commented
Sep 10, 2026
| 'Error': error_messages, | ||
| }) | ||
|
|
||
| def get_score(self, real_data, synthetic_data, metadata, constraints=None, progress_bar=None): |
Contributor
Author
There was a problem hiding this comment.
overriding this method to have constraints
sarahmish
commented
Sep 10, 2026
| "detailed score breakdowns, use the 'get_details' function." | ||
| ) | ||
|
|
||
| def get_details(self, table_name=None): |
Contributor
Author
There was a problem hiding this comment.
overriding get_details to always return the details dataframe since this property is not defined by tables.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## issue-899-constraint-adherence-multi-table #936 +/- ##
==============================================================================
+ Coverage 96.05% 96.08% +0.02%
==============================================================================
Files 145 146 +1
Lines 6747 6786 +39
==============================================================================
+ Hits 6481 6520 +39
Misses 266 266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #900