Update the benchmark to load datasets from multiple S3 buckets when None is specified#607
Merged
Conversation
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
==========================================
+ Coverage 85.67% 85.91% +0.24%
==========================================
Files 40 40
Lines 3679 3749 +70
==========================================
+ Hits 3152 3221 +69
- Misses 527 528 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
R-Palazzo
commented
May 26, 2026
R-Palazzo
force-pushed
the
issue-604-2-private-bucket
branch
2 times, most recently
from
95be93a to
9a91033
Compare
amontanez24
reviewed
May 27, 2026
|
|
||
| def _get_dataset_bucket_mapping(modality, buckets, s3_client, skip_inaccessible=False): | ||
| """Map SDV demo dataset names to the bucket they should be loaded from.""" | ||
| dataset_buckets = {} |
Contributor
There was a problem hiding this comment.
nitpick: can we call dataset_to_bucket
R-Palazzo
force-pushed
the
issue-604-2-private-bucket
branch
from
725c22c to
5555441
Compare
R-Palazzo
commented
May 28, 2026
| """Main SDGym benchmarking module.""" | ||
|
|
||
| import functools | ||
| import gzip |
Collaborator
Author
There was a problem hiding this comment.
Since the dataset is no longer included in the job_arg_list, we don't need to compress it. Also, it now contains one job by default, and from my tests, it's roughly 1KB.
frances-h
approved these changes
May 28, 2026
sarahmish
reviewed
Jun 1, 2026
Comment on lines
+887
to
+891
| def _get_s3_client_from_result_writer(result_writer): | ||
| if isinstance(result_writer, S3ResultsWriter): | ||
| return result_writer.s3_client | ||
|
|
||
| return None |
Contributor
There was a problem hiding this comment.
Just want to note that in the future, we should setup the s3 client independently from using the same credentials as writing the results.
R-Palazzo
force-pushed
the
issue-604-2-private-bucket
branch
from
b97fa0d to
0786528
Compare
sarahmish
reviewed
Jun 1, 2026
R-Palazzo
force-pushed
the
issue-604-2-private-bucket
branch
from
4bd6e85 to
4907bb3
Compare
R-Palazzo
force-pushed
the
issue-604-2-private-bucket
branch
from
4907bb3 to
e4bfb1d
Compare
sarahmish
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #604
CU-86b9zwpcu
This PR includes:
download_demo()to getsdv_dataset. This works for public datasets or for users with SDV-Enterprise installed. Otherwise, because on SDV there is some validation to allow access to the public bucket only, I reused the SDV logic here, so it works if the S3 client is created with valid credentials (from input keys or env variables).download_demo(), we no longer save the dataset locally._generate_job_arg_list: Now we're only passingdataset_infoinside it. Thedataset_infoincludes everything necessary to then download the data and metadata during execution.