Skip to content

test: replace deprecated spatial_neighbors with mode-specific functions#1219

Open
selmanozleyen wants to merge 10 commits into
scverse:mainfrom
selmanozleyen:tests/drop-deprecated-spatial-neighbors
Open

test: replace deprecated spatial_neighbors with mode-specific functions#1219
selmanozleyen wants to merge 10 commits into
scverse:mainfrom
selmanozleyen:tests/drop-deprecated-spatial-neighbors

Conversation

@selmanozleyen

Copy link
Copy Markdown
Member

Converts incidental uses of the deprecated spatial_neighbors to the new mode-specific functions (spatial_neighbors_grid/_knn/_radius). Leaves tests/graph/test_spatial_neighbors.py untouched since it intentionally exercises the deprecated path.

@selmanozleyen selmanozleyen requested a review from timtreis June 19, 2026 12:48
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.96%. Comparing base (005c905) to head (0e854f1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
+ Coverage   76.81%   76.96%   +0.15%     
==========================================
  Files          63       63              
  Lines        9269     9269              
  Branches     1565     1565              
==========================================
+ Hits         7120     7134      +14     
+ Misses       1547     1533      -14     
  Partials      602      602              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@selmanozleyen selmanozleyen added the release-ignore Exclude from generated release notes label Jun 20, 2026
@selmanozleyen selmanozleyen self-assigned this Jun 20, 2026
@timtreis

timtreis commented Jul 7, 2026

Copy link
Copy Markdown
Member

Missed one I think (see pre-commit)

The merge from main reintroduced a bare deprecated spatial_neighbors call
in TestNhoodEnrichment.test_n_jobs_invariance, which this branch no longer
imports. Match the sibling tests in the class.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-ignore Exclude from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants