Skip to content

chore: add flaky marker to pyproject#1179

Open
selmanozleyen wants to merge 3 commits into
scverse:mainfrom
selmanozleyen:chore/flaky-marker
Open

chore: add flaky marker to pyproject#1179
selmanozleyen wants to merge 3 commits into
scverse:mainfrom
selmanozleyen:chore/flaky-marker

Conversation

@selmanozleyen
Copy link
Copy Markdown
Member

similar to the gpu marker we needed to add even though the CI's worked here: #1140. We need to add the flaky marker explicitly here.

@selmanozleyen selmanozleyen changed the title add flaky marker chore: add flaky marker to pyproject May 15, 2026
@selmanozleyen selmanozleyen self-assigned this May 15, 2026
Copy link
Copy Markdown
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency isn’t called flaky, it’s pytest-rerunfailures. And the marker section is only for markers we add, plugins will register their markers:

  1. pytest will discover and load the plugin if the package is installed: https://github.com/pytest-dev/pytest-rerunfailures/blob/9f792d9efe6bf0218e7ba2734257af2d5165ca3f/pyproject.toml#L48
  2. the plugin will register the marker: https://github.com/pytest-dev/pytest-rerunfailures/blob/9f792d9efe6bf0218e7ba2734257af2d5165ca3f/src/pytest_rerunfailures.py#L343-L350

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.82%. Comparing base (093217d) to head (1068bba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1179   +/-   ##
=======================================
  Coverage   73.82%   73.82%           
=======================================
  Files          45       45           
  Lines        7013     7013           
  Branches     1188     1188           
=======================================
  Hits         5177     5177           
  Misses       1349     1349           
  Partials      487      487           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@selmanozleyen
Copy link
Copy Markdown
Member Author

The dependency isn’t called flaky, it’s pytest-rerunfailures. And the marker section is only for markers we add, plugins will register their markers:

1. pytest will discover and load the plugin if the package is installed: https://github.com/pytest-dev/pytest-rerunfailures/blob/9f792d9efe6bf0218e7ba2734257af2d5165ca3f/pyproject.toml#L48

2. the plugin will register the marker: https://github.com/pytest-dev/pytest-rerunfailures/blob/9f792d9efe6bf0218e7ba2734257af2d5165ca3f/src/pytest_rerunfailures.py#L343-L350

But this means we got flaky from somewhere else because pytest-rerunfailures takes reruns as parameter but it worked ok when I used to give it max_runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants