Skip to content

Fix contributor dependency installation instructions - #769

Merged
timtreis merged 1 commit into
scverse:mainfrom
jan-glx:agent/fix-contributor-dependency-groups
Aug 18, 2026
Merged

Fix contributor dependency installation instructions#769
timtreis merged 1 commit into
scverse:mainfrom
jan-glx:agent/fix-contributor-dependency-groups

Conversation

@jan-glx

@jan-glx jan-glx commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Mirroring scverse/spatialdata#1174 this PR replaces the obsolete editable-install extras syntax in the pip contribution instructions with pip dependency groups.

Development dependencies are declared under [dependency-groups], not [project.optional-dependencies]. As a result, following the current instructions, pip install -e ".[dev,test,doc]" warns that those extras do not exist and does not install the contributor dependencies.
The updated instructions uses groups: pip install -e . --group dev --group test --group doc - which will actually install the declared dependencies.

@jan-glx
jan-glx marked this pull request as ready for review August 18, 2026 09:14
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.93%. Comparing base (8bcfe6c) to head (7f9d3b4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #769   +/-   ##
=======================================
  Coverage   79.93%   79.93%           
=======================================
  Files          18       18           
  Lines        4814     4814           
  Branches     1069     1069           
=======================================
  Hits         3848     3848           
  Misses        604      604           
  Partials      362      362           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timtreis

Copy link
Copy Markdown
Member

Thanks @jan-glx !

@timtreis
timtreis self-requested a review August 18, 2026 14:05

@timtreis timtreis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timtreis
timtreis merged commit 375c173 into scverse:main Aug 18, 2026
8 checks passed
@jan-glx
jan-glx deleted the agent/fix-contributor-dependency-groups branch August 18, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants