Skip to content

Fix render_labels silently accepting fill_alpha=0 and outline_alpha=0 #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtreis merged 1 commit into from
May 8, 2026
Merged

Fix render_labels silently accepting fill_alpha=0 and outline_alpha=0 #644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/spatialdata_plot/pl/render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1764,6 +1764,11 @@ def _draw_labels(
if effective_outline_color is None and col_for_color is None and render_params.color is not None:
effective_outline_color = render_params.color

if render_params.fill_alpha == 0.0 and render_params.outline_alpha == 0.0:
raise ValueError(
"Parameters 'fill_alpha' and 'outline_alpha' cannot both be 0. Set at least one to a positive value."
)

# default case: no contour, just fill
# since contour_px is passed to skimage.morphology.erosion to create the contour,
# any border thickness is only within the label, not outside. Therefore, the case
Expand Down
Loading