Skip to content

Merge pull request #1627 from scroll-tech/fix/blog-nav-link #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzq0826 merged 1 commit into from
Sep 21, 2026
+5 −13
Merged

Merge pull request #1627 from scroll-tech/fix/blog-nav-link #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions scripts/build-landing.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,9 @@ once(
once("white paper link", 'href="/scroll-whitepaper.pdf"', 'href="/files/whitepaper.pdf"')
// the blog is a page of its own again (Zhengqi, 2026-09-21): it went off the site with the
// rest of the old pages in the redesign, and the link people were sent to it with has been
// dead since. It sits in the nav after the product sections and opens the footer's
// Resources column, here and in LandingFooter.tsx (the other pages' footer) alike.
once(
"blog nav link",
'<li><a class="nav__link" href="#hardware">AI hardware</a></li>',
'<li><a class="nav__link" href="#hardware">AI hardware</a></li>\n <li><a class="nav__link" href="/blog">Blog</a></li>',
)
// dead since. It opens the footer's Resources column, here and in LandingFooter.tsx (the
// other pages' footer) alike. Not in the nav — that bar is the product's own sections, and
// the footer link is reach enough (Zhengqi, 2026-09-21).
once(
"blog footer link",
'<a href="https://docs.scroll.io/en/home/" target="_blank" rel="noopener">Documentation</a>',
Expand Down
8 changes: 2 additions & 6 deletions src/app/_components/LandingNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ const NAV_LINKS = [
{ label: "Compass", href: "/#compass" },
{ label: "ZK API keys", href: "/#api" },
{ label: "AI hardware", href: "/#hardware" },
// the blog went off the site with the rest of the old pages in the redesign; it is a
// page of its own, not a section of the front page (Zhengqi 2026-09-21)
{ label: "Blog", href: "/blog" },
]

/** true once the page has scrolled past `threshold`; read on a frame, not on every event */
Expand Down Expand Up @@ -58,11 +55,10 @@ const LandingNav = ({ collapsible = false }: LandingNavProps) => {
const [open, setOpen] = useState(false)
const scrolled = useScrolled(24, collapsible)

// on the landing page itself, scroll smoothly instead of re-navigating (Home would jump
// otherwise). Links to another page — the blog — are left alone.
// on the landing page itself, scroll smoothly instead of re-navigating (Home would jump otherwise)
const handleNavClick = (e: MouseEvent<HTMLAnchorElement>, href: string) => {
setOpen(false)
if (pathname !== "/" || (href !== "/" && !href.startsWith("/#"))) return
if (pathname !== "/") return
e.preventDefault()
const id = href.split("#")[1]
if (id) {
Expand Down
Loading