-
Notifications
You must be signed in to change notification settings - Fork 22
add galileo CodecV9 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package encoding | ||
|
|
||
| type DACodecV9 struct { | ||
Thegaram marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| DACodecV8 | ||
| } | ||
|
|
||
| func NewDACodecV9() *DACodecV9 { | ||
| v := CodecV9 | ||
| return &DACodecV9{ | ||
| DACodecV8: DACodecV8{ | ||
| DACodecV7: DACodecV7{forcedVersion: &v}, | ||
| }, | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,40 @@ | ||
| module github.com/scroll-tech/da-codec | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| require ( | ||
| github.com/agiledragon/gomonkey/v2 v2.12.0 | ||
| github.com/scroll-tech/go-ethereum v1.10.14-0.20250625112225-a67863c65587 | ||
| github.com/stretchr/testify v1.9.0 | ||
| github.com/scroll-tech/go-ethereum v1.10.14-0.20251113125950-906b730d541d | ||
| github.com/stretchr/testify v1.10.0 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/bits-and-blooms/bitset v1.12.0 // indirect | ||
| github.com/crate-crypto/go-eth-kzg v1.4.0 // indirect | ||
| github.com/ethereum/c-kzg-4844/v2 v2.1.5 // indirect | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/bits-and-blooms/bitset v1.20.0 // indirect | ||
| github.com/btcsuite/btcd v0.20.1-beta // indirect | ||
georgehao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| github.com/consensys/bavard v0.1.13 // indirect | ||
| github.com/consensys/gnark-crypto v0.12.1 // indirect | ||
| github.com/crate-crypto/go-kzg-4844 v1.0.0 // indirect | ||
| github.com/consensys/bavard v0.1.27 // indirect | ||
| github.com/consensys/gnark-crypto v0.16.0 // indirect | ||
georgehao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/ethereum/c-kzg-4844/bindings/go v0.0.0-20230126171313-363c7d7593b4 // indirect | ||
| github.com/go-ole/go-ole v1.3.0 // indirect | ||
| github.com/go-stack/stack v1.8.1 // indirect | ||
| github.com/holiman/uint256 v1.2.4 | ||
| github.com/iden3/go-iden3-crypto v0.0.15 // indirect | ||
| github.com/klauspost/compress v1.17.9 | ||
| github.com/kr/text v0.2.0 // indirect | ||
| github.com/mmcloughlin/addchain v0.4.0 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| github.com/rogpeppe/go-internal v1.10.0 // indirect | ||
| github.com/scroll-tech/zktrie v0.8.4 // indirect | ||
| github.com/shirou/gopsutil v3.21.11+incompatible // indirect | ||
| github.com/supranational/blst v0.3.11 // indirect | ||
| github.com/supranational/blst v0.3.15 // indirect | ||
| github.com/tklauser/go-sysconf v0.3.12 // indirect | ||
| github.com/tklauser/numcpus v0.6.1 // indirect | ||
| github.com/yusufpapurcu/wmi v1.2.3 // indirect | ||
| golang.org/x/crypto v0.21.0 // indirect | ||
| golang.org/x/sync v0.6.0 // indirect | ||
| golang.org/x/sys v0.21.0 // indirect | ||
| golang.org/x/crypto v0.32.0 // indirect | ||
| golang.org/x/sync v0.10.0 // indirect | ||
| golang.org/x/sys v0.29.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| rsc.io/tmplfunc v0.0.3 // indirect | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember that we need to bump
da-codecversion in bothrollup-relayerandl2geth(I think previously we forgot about l2geth).Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blob-uploader depends on da-code as well, Do we already have plan to update blob-uploader here to support codecv9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, it's already covered on pr https://github.com/scroll-tech/scroll/pull/1752/files#diff-516f715f986f16ab3c638b2e3652d9bf4af757c33fd880a0964dea26c2d48f2dR1053.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in this pr scroll-tech/scroll#1752